[BNE] Misprints in audit log

Description

There are some typos in the audit log:

  1. ModifyBusinessIdentityFlow prints StateAndRef instead of membership id in the following message:

     

  2. RequestMembershipAttributeChangeFlow doesn't show roles info if we are trying to modify the both: businessIdentity and roles:

     

Please find the logs attached.

Activity

Show:
Alexey Chernikov
November 29, 2020, 7:19 AM

Checked. All the tests are passed.

Components/versions tested: bne-1.1-RC03, corda-4.7-RC03

Logs and configs are attached.

 

Bogdan Paunescu
November 23, 2020, 5:59 PM

Yes, was double checking. I confirmed the bug. Thank you!

Alexey Chernikov
November 23, 2020, 5:55 PM
Edited

Hi

Sorry, I forgot to attach RequestBICAndRoleChangeFlow sources. Please find attached.

So, I’ve just executed RequestMembershipAttributeChangeFlow sub-flow: subFlow(RequestMembershipAttributeChangeFlow(authorisedParty, networkId, bankIdentity, ourMembership.roles + LoanIssuerRole(), notary))

It seems to be an if-else chain and '+' priorities issue in RequestMembershipAttributeChangeFlow.

Bogdan Paunescu
November 23, 2020, 5:45 PM

Question about the 2nd issue in this ticket, I’m looking at the attached logs and it seems the attribute change request flow is called only for a new identity not a new set of roles as well. In that case, there’s nothing to display, the code works as intended.

Done

Assignee

Alexey Chernikov

Reporter

Alexey Chernikov

Labels

Sprint

None

Epic Link

None

Priority

Medium

Engineering Teams

None

Fix versions

Affects versions

Ported to...

None

Story Points / Dev Days

None

Build cut

None

Squad

None