[RPC] RPC client makes one reconnection attempt on startFlowDynamic if node doesn't have target cordapps

Description

Prerequisites:
RPC client with cordapps installed, but target node has no cordapps

Steps to reproduce:
Execute flow via RPC client

Expected result:
Flow fails, RPC client doesn’t do reconnections

Actual result:
RPC client does one reconnection

Activity

Show:
ryan.fowler
February 7, 2020, 3:37 PM

I believe this is on purpose:

what was the reasoning for not retrying start flows?

Shams Asari
February 7, 2020, 4:38 PM

Because it’s possible the flow did start on the node. The starting of a flow via RPC is not atomic, which is why the docs talk about a checking before retrying.

ryan.fowler
February 11, 2020, 2:13 PM

Sorry, I misread. The above is true, but I think the point is that it tried at all. This may (or should) be fixed by in 4.5

ryan.fowler
February 14, 2020, 4:25 PM

I think this should be fixed with the latest RC. I just ran against a 4.4 snapshot (pre RC03) of the Bank of Corda demo without corDapps and got the following:

 

So no attempt at reconnection. does that look like a reasonable recreation of your test?

Dmitry Toropov
February 25, 2020, 4:57 PM
Edited

Passed.

Components: Components: Corda OS/ENT 4.4 RC03, CENM 1.1

 

Assignee

Dmitry Toropov

Reporter

Dmitry Toropov

Sprint

None

Epic Link

None

Priority

Medium

Severity

Medium

CVSS Score

None

CVSS Vector

None

Due Date

None

Engineering Teams

Kernel

Fix versions

Affects versions

Ported to...

None

Story Points / Dev Days

None
Configure