CorDapp rolling upgrades: It is not possible to perform transactions between nodes whose Cordapps have different versions but are signed by the same key: contract V2 -> contract V1.

Description

Steps to reproduce:
1. Get the following files OS jars from https://ci-artifactory.corda.r3cev.com/artifactory/corda-releases/net/corda/

  • corda-finance-workflows-4.3-RC01.jar

  • corda-finance-contracts-4.3-RC01.jar

2. Clone Corda from repository:

3. Create a modified finance-contracts JAR file. After clone Corda from repository go to corda/finance/:

  • contracts folder, in build.gradle file change from versionId 1 to versionId 2.

  • finance-contract module, in ./contracts/src/main/kotlin/net/corda/finance/contracts/asset/Cash.kt add:

a) parameter val foobar: Int? = 5 .

b) fun copy(amount: Amount<Issued>, owner: AbstractParty) = copy(amount = amount, owner = owner, foobar = null) .

Build the JAR file (../../gradlew jar) and rename to corda-finance-contracts-4.1-RC03-V2.jar

4. Outside test dir create SigningKey directory and generate KeyStore there.

5. Sign each finance-contract JAR by the same Code Signing key from the previous step.

6. Bootstrap corda network (PartyA / PartyB / Notary) and copy cordapps:

  • corda-finance-workflows-4.1-RC03.jar to PartyA and PartyB

  • corda-finance-contracts-4.1-RC03.jar to PartyA

  • corda-finance-contracts-4.1-RC03-V2.jar to PartyB

7. Start all Nodes and connect via ssh to nodes.

8. Run "uploadAttachment" from the PartyA / PartyB shell:
>>> run uploadAttachment jar: /home/maxim.shadrin/sources/4.3-RC01/PartyB/cordapps/corda-finance-contracts-4.3-RC01-V2.jar
"54BDCAA2EDB4294E9A7B438FDC7EA64840E3571CA3ADF68F2C54DFA71E494F6A"
>>> run uploadAttachment jar: /home/maxim.shadrin/sources/4.3-RC01/PartyA/cordapps/corda-finance-contracts-4.3-RC01.jar
"3C971E61271A1414A191F2B9BEEC5046D9CF3E21FE1D8EECF0B4C0B38F9F757D"

Scenario one:
9. Perform transactions PartyA/V1 -> PartyB/V2.

  • issue cash from PartyA

  • transfer issued cash to PartyB

Scenario two:
11. Perform transactions PartyB/V2 -> PartyA/V1.

  • issue cash from PartyB:

  • transfer issued cash to PartyA:

Expected result:
Both Nodes A and B transact seamlessly, where

  • Node A builds transactions using V1, verifies remote transactions using V2, be able to consume the cash from V2.

  • Node B builds transactions using V2, verifies remote transactions using V2, be able to consume the cash from V1.

Actual result:
Scenario one works as expected.
Scenario two is failed at step "transfer cash to PartyA" (step 11). The node is shutting down. The logs contain the exception “Not enough money to spend: not enough money, missing 85.00 EUR” and the Java heap space error log appeared in the PartyB directory. Please see the detailed scenario in attachments.

Status

Assignee

Dmitry Tatarinov

Reporter

Maxim Shadrin

Priority

High

Ported to...

Corda 4.3
Corda Enterprise 4.1
Corda Enterprise 4.2
Corda Enterprise 4.3

Feature Team

Kernel Group

CVSS Vector

None

Severity

Medium

Affected OS

Linux

Time tracking

4h

Sprint

None

Affects versions

Configure