We're updating the issue view to help you get more done. 

Should Jolokia be included in the built jar files?

Description

Tommy was having some trouble with hqlax having multiple copies of the Jolokia classes, this then giving warnings.

The other day I noticed that we include Jolokia in the Cordapp jars generated by some of the sample projects. This doesn't feel right - surely Jolokia is a node concern, and not a Cordapp concern?

I've tested two of the sample apps so far, both using the RC03 enterprise dev pack:

  • reference-states - Jolokia is included in reference-states-0.1.jar

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 ~/dev/r3/r3qa/solutions/R3T-1918/samples/reference-states   release-V4-enterprise ●  jar -tvf build/libs/reference-states-0.1.jar 37242 Tue Feb 26 17:52:30 GMT 2019 META-INF/MANIFEST.MF 37271 Tue Feb 26 17:52:30 GMT 2019 META-INF/CORDACOD.SF 733 Tue Feb 26 17:52:30 GMT 2019 META-INF/CORDACOD.EC 0 Tue Feb 26 17:52:30 GMT 2019 META-INF/ 340 Mon Jun 25 20:24:56 BST 2018 META-INF/detectors-default 0 Mon Jun 25 20:25:36 BST 2018 META-INF/maven/ 0 Tue Mar 20 16:23:38 GMT 2012 META-INF/maven/com.googlecode.json-simple/ 0 Tue Mar 20 16:23:38 GMT 2012 META-INF/maven/com.googlecode.json-simple/json-simple/ 151 Tue Mar 20 16:23:38 GMT 2012 META-INF/maven/com.googlecode.json-simple/json-simple/pom.properties 3464 Tue Mar 20 16:14:44 GMT 2012 META-INF/maven/com.googlecode.json-simple/json-simple/pom.xml 0 Mon Jun 25 20:25:36 BST 2018 META-INF/maven/org.jolokia/ 0 Mon Jun 25 20:25:36 BST 2018 META-INF/maven/org.jolokia/jolokia-core/ 109 Mon Jun 25 20:25:34 BST 2018 META-INF/maven/org.jolokia/jolokia-core/pom.properties 3122 Mon Jun 25 20:23:44 BST 2018 META-INF/maven/org.jolokia/jolokia-core/pom.xml 0 Mon Jun 25 20:27:34 BST 2018 META-INF/maven/org.jolokia/jolokia-jvm/ 108 Mon Jun 25 20:27:34 BST 2018 META-INF/maven/org.jolokia/jolokia-jvm/pom.properties 8957 Mon Jun 25 20:23:44 BST 2018 META-INF/maven/org.jolokia/jolokia-jvm/pom.xml 277 Mon Jun 25 20:24:56 BST 2018 META-INF/simplifiers-default 2167 Mon Jun 25 20:27:08 BST 2018 default-jolokia-agent.properties 0 Mon Jun 25 20:24:56 BST 2018 org/ 0 Mon Jun 25 20:24:56 BST 2018 org/jolokia/ 524 Mon Jun 25 20:24:56 BST 2018 org/jolokia/Version.class 0 Mon Jun 25 20:24:56 BST 2018 org/jolokia/backend/ 230 Mon Jun 25 20:2
  • negotiation Cordapp has 3 jars, only the root jar has Jolokia:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 ~/dev/r3/r3qa/solutions/R3T-1514   7-r3t-2145-firewall-template-obfuscation ●  jar -tvf samples/negotiation-cordapp/build/libs/negotiation-cordapp-0.2.jar 37230 Wed Feb 27 07:59:10 GMT 2019 META-INF/MANIFEST.MF 37271 Wed Feb 27 07:59:10 GMT 2019 META-INF/MYKEYALI.SF 1208 Wed Feb 27 07:59:10 GMT 2019 META-INF/MYKEYALI.RSA 0 Wed Feb 27 07:59:10 GMT 2019 META-INF/ 340 Mon Jun 25 20:24:56 BST 2018 META-INF/detectors-default 0 Mon Jun 25 20:25:36 BST 2018 META-INF/maven/ 0 Tue Mar 20 16:23:38 GMT 2012 META-INF/maven/com.googlecode.json-simple/ 0 Tue Mar 20 16:23:38 GMT 2012 META-INF/maven/com.googlecode.json-simple/json-simple/ 151 Tue Mar 20 16:23:38 GMT 2012 META-INF/maven/com.googlecode.json-simple/json-simple/pom.properties 3464 Tue Mar 20 16:14:44 GMT 2012 META-INF/maven/com.googlecode.json-simple/json-simple/pom.xml 0 Mon Jun 25 20:25:36 BST 2018 META-INF/maven/org.jolokia/ 0 Mon Jun 25 20:25:36 BST 2018 META-INF/maven/org.jolokia/jolokia-core/ 109 Mon Jun 25 20:25:34 BST 2018 META-INF/maven/org.jolokia/jolokia-core/pom.properties 3122 Mon Jun 25 20:23:44 BST 2018 META-INF/maven/org.jolokia/jolokia-core/pom.xml 0 Mon Jun 25 20:27:34 BST 2018 META-INF/maven/org.jolokia/jolokia-jvm/ 108 Mon Jun 25 20:27:34 BST 2018 META-INF/maven/org.jolokia/jolokia-jvm/pom.properties 8957 Mon Jun 25 20:23:44 BST 2018 META-INF/maven/org.jolokia/jolokia-jvm/pom.xml 277 Mon Jun 25 20:24:56 BST 2018 META-INF/simplifiers-default 2167 Mon Jun 25 20:27:08 BST 2018 default-jolokia-agent.properties 0 Mon Jun 25 20:24:56 BST 2018 org/ 0 Mon Jun 25 20:24:56 BST 2018 org/jolokia/ 524 Mon Jun 25 20:24:56 BS

Status

Assignee

Chris Rankin

Reporter

Ben Wyeth

Priority

Medium

Labels

Severity

Medium

Fix versions

None

Ported to...

None

Feature Team

Select team

Affects versions

Corda 4
Corda Enterprise 4 RC03