CordaRPCClientConfiguration.default not accessible in java as default is a reserved word

Description

Upgrade the cordapp example to the most recent version of corda

In exampleClientRpc.java line 35 change the line:

final CordaRPCClient client = new CordaRPCClient(nodeAddress, CordaRPCClientConfiguration.DEFAULT);

to

final CordaRPCClient client = new CordaRPCClient(nodeAddress, CordaRPCClientConfiguration.Companion.default());

And get a compilation error because default is a reserved word in java.

Change was made in this commit:

Activity

Show:
Tommy Lillehagen
June 11, 2018, 5:06 PM
Michele Sollecito
June 12, 2018, 8:21 AM

An easy fix would be introducing a `fun defaultValue(): CordaRPCClientConfiguration`, and to deprecate the existing one instead.

We would also benefit from running a check against a set of keywords in the API checker.

Tommy Lillehagen
June 12, 2018, 8:39 AM

Yes, I've already raised

Katelyn Baker
July 13, 2018, 3:00 PM

Unsquashed commit = I'm not backporting this, need to raise a new PR for release-V3

Tommy Lillehagen
July 13, 2018, 3:08 PM
Edited

No need - this RPC API breakage was introduced after V3 and V3.1 and never made it onto release-V3, so this should be good. The PR on this ticket simply reverted the API compatibility breakage.

Assignee

Tommy Lillehagen

Reporter

Anthony Keenan

Labels

Sprint

None

Epic Link

None

Priority

Medium

Severity

Medium

CVSS Score

None

CVSS Vector

None

Due Date

None

Engineering Teams

None

Fix versions

None

Affects versions

Ported to...

None

Story Points / Dev Days

None
Configure